-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batching support #122
Merged
Merged
Batching support #122
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
fedbfc9
Very naive batching implementation
pirelenito e86aaf0
Batches effects of other batches
pirelenito b40aac3
Extract batch to a separated module and make it apply to Facet by def…
pirelenito cfc9947
WIP: logging extra usage
pirelenito 876e796
Remove log and schedule on effects
pirelenito 0290201
Logs scheduler success ration
pirelenito 0b02ec7
Rename batch into scheduler
pirelenito 131e09f
Documentation
pirelenito 72133f6
Only starts a batch on createFacet if we are notifying a change
pirelenito 642c8f2
Also test useFacetEffect
pirelenito 706e845
Keep batch started until the end
pirelenito 2233682
Fix linter
pirelenito f27c521
Expose batch as a public API
pirelenito fb55b16
Small refactor
pirelenito 509fb14
Make sure to cancel tasks that are no longer needed
pirelenito 7bebd8d
Testing order of execution of scheduled tasks within batches
pirelenito f90b7a5
Fix cancelation of tasks
pirelenito 0fea214
Rename canceled to scheduled
pirelenito e7df766
Uses an array to keep track of tasks
pirelenito f4610a3
Using a "regular for" should be faster
pirelenito 6b49be3
Unit test canceling tasks
pirelenito b6086de
Cleanup development log, plus some extra docs
pirelenito 2c3b273
Avoids scheduling for first event within a batch
pirelenito c79e33d
Merge branch 'main' into batch
pirelenito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remain consistent and export with
*
. I know there are other two functions being exported and maybe they were meant as internal, but I think there's value in exposing them, we don't yet know if there is no use for them in third party library code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, the reason was to keep them private.
The main risk with open-source packages is that once an API is public and used... its a wider surface we need to keep compatible.