Rename useFacetEffect to useFacetLayoutEffect and add a new useFacetEffect #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f useFacetLayoutEffect
|
There is now a handful of code that is duplicated between We ended up deciding not to do so for now, however. We decided to prioritized keeping the code easily readable and to keep the logic between different functions completely separated, even if it is similar. |
xaviervia
approved these changes
Jan 28, 2022
| @@ -6,7 +6,7 @@ module.exports = { | |||
| 'react-hooks/exhaustive-deps': [ | |||
| 'error', | |||
| { | |||
| additionalHooks: '(useFacetEffect|useFacetMap|useFacetMemo|useFacetCallback)', | |||
| additionalHooks: '(useFacetLayoutEffect|useFacetEffect|useFacetMap|useFacetMemo|useFacetCallback)', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the
useFacetEffectfunction is slightly misleading in the current implementation, as it is actually using React'suseLayoutEffectas an underlying function. Thus, we have renamed the function touseFacetLayoutEffectand added a new function calleduseFacetEffectin its place that actually uses React'suseEffect.We have updated the documentation to reflect this change in a separate pull request (#31).