Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line endings settings for prettier #77

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

pirelenito
Copy link
Member

@pirelenito pirelenito commented Jul 11, 2022

This is a follow-up to #64, but we also fix the settings for Prettier. More info at https://stackoverflow.com/a/53769213

I'm also changing our GitHub Action to run the linter on Windows and macOS as well, so we can validate it works.

Line Endings Behavior

We have it configured to auto which means that on Windows platforms we will get the default behavior for that platform CRLF and on macOS and Linux we will get the default for there LF.

@pirelenito pirelenito enabled auto-merge (squash) July 11, 2022 09:26
@pirelenito pirelenito disabled auto-merge July 11, 2022 09:27
@pirelenito pirelenito merged commit c36a0cd into main Jul 11, 2022
@pirelenito pirelenito deleted the fix-prettier-windows-line-endings branch July 11, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants