Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize automated performance tests #9

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

pirelenito
Copy link
Member

@pirelenito pirelenito commented Nov 3, 2021

There is currently a very high variation on the performance numbers we are getting when running via GitHub actions.

This PR does three main changes:

  • Increases the time we take to collect samples for the markerFacet example.
  • Changes the target performance number for listMemoFacet to 70.
  • Make the script only fail when we go above the target (it would fail when going below as well).

We are still learning what are the best practices on automating this checks, and for the meantime we should still not have them as merge blockers (given they are not yet quite stable).

@pirelenito pirelenito merged commit b037e66 into main Nov 3, 2021
@pirelenito pirelenito deleted the stabilize-performance-tests branch November 3, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants