Minor cleanups for v0.2.5 #31
Conversation
| @@ -1,4 +1,3 @@ | |||
|
|
|||
There was a problem hiding this comment.
Better to put in a yapf disable around whole file than let a versioneer generates file be edited, right?
There was a problem hiding this comment.
I would say, yes. But since we do not regenerate these, I say just YAPF once and get on with it.
There was a problem hiding this comment.
So long as doesn’t interfere with upgrading versioneer, sounds fine. (I don’t think it should, just the one complication that comes to mind)
There was a problem hiding this comment.
I don't think versioneer will even be upgraded again to be honest. I think that repository is dead and PyPA is creating a replacement. See here.
docs/source/changelog.rst
Outdated
| Enhancements | ||
| ++++++++++++ | ||
|
|
||
| - (:pr:`31`) Lints the code base preparign for a release and minor test improvements. |
qcelemental/data/nist_2014_codata.py
Outdated
| @@ -2033,4 +2033,4 @@ | |||
| 'uncertainty': '0.000 0017 e-3' | |||
| } | |||
| } | |||
| } | |||
| } # yapf: disable | |||
| data = water_molecule.dict() | ||
| data["geometry"] = list(range(8)) | ||
| with pytest.raises(ValidationError): | ||
| Molecule(**data) |
There was a problem hiding this comment.
For these very generic errors, if there’s more specific info in the error msg, it’s sometimes handy to test the string contents too.
There was a problem hiding this comment.
Agreed, best to put it on a TODO.
iSorts and YAPFs the entire code base + enhancement of tests.