Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provenance #7

Merged
merged 4 commits into from Oct 26, 2018
Merged

Provenance #7

merged 4 commits into from Oct 26, 2018

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Oct 26, 2018

  • Adds "comment" and "provenance" fields to internal repr to better match QCSchema
  • Adds provenance stamp to from_string, from_arrays, from_schema fns
  • Adds outer schema_name/schema_version to to_schema(..., dtype=1) output so to_/from_schema are inverses

@dgasmith dgasmith merged commit 68aa684 into master Oct 26, 2018
@loriab loriab deleted the provenance branch October 26, 2018 16:14
This was referenced Oct 28, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgasmith dgasmith dgasmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loriab @dgasmith