Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip broken intel-openmp 2019.5-281 #156

Merged
merged 5 commits into from Sep 21, 2019

Conversation

mattwelborn
Copy link
Contributor

This PR skips intel-openmp version 2019.5-281, which breaks geometric+psi4. See also ContinuumIO/anaconda-issues#11294.

Copy link
Collaborator

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as Fractal, but LGTM.

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #156 into master will increase coverage by 2.67%.
The diff coverage is 100%.

@dgasmith
Copy link
Collaborator

Unsure how this made it through, but you need a:

ret_data["extras"].update({
...
})

here instead of a set.

@dgasmith dgasmith merged commit f63e481 into MolSSI:master Sep 21, 2019
@mattwelborn mattwelborn deleted the no_intelopenmp_2019_5 branch October 1, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants