Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model Update #34

Merged
merged 5 commits into from Feb 27, 2019
Merged

Model Update #34

merged 5 commits into from Feb 27, 2019

Conversation

dgasmith
Copy link
Collaborator

Moves several items around in preparation of strict keys in the base model which will happen in QCElemental v0.3 slated for later this week. Also:

  • tweaks stdout/stderr so that it is correctly omitted when no data is saved
  • Input errors are now correctly handled and raised.

@dgasmith dgasmith added the Enhancement Expansion of a pre-existing feature. label Feb 27, 2019
@dgasmith dgasmith added this to the v0.6.0 milestone Feb 27, 2019
@dgasmith
Copy link
Collaborator Author

This will require a new QCElemental release.

@codecov
Copy link

codecov bot commented Feb 27, 2019 •
edited

Codecov Report

Merging #34 into master will decrease coverage by 0.01%.
The diff coverage is 90.69%.

loriab
loriab approved these changes Feb 27, 2019
View reviewed changes
Copy link
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane to me

@dgasmith dgasmith merged commit fac06fd into MolSSI:master Feb 27, 2019
@dgasmith dgasmith deleted the models branch February 27, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loriab loriab loriab approved these changes

Assignees
No one assigned
Labels
Enhancement Expansion of a pre-existing feature.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgasmith @loriab