Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better config loading #383

Merged
merged 1 commit into from
Nov 15, 2022
Merged

better config loading #383

merged 1 commit into from
Nov 15, 2022

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Nov 15, 2022

Description

Fixes #379 . @bennybp, I think that's all about loading qca config files. Those are all POD, right, not trying to create objects such that FullLoader would be needed?

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Nov 15, 2022 •
edited

Codecov Report

Merging #383 (785fbda) into master (4232350) will increase coverage by 2.74%.
The diff coverage is 0.00%.

Additional details and impacted files

WardLT
WardLT approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@WardLT WardLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a needed change, and is something I've manually edited in many of my QCEngine installations before. LGTM

@loriab loriab merged commit 3a3da1f into master Nov 15, 2022
@loriab loriab deleted the loriab-patch-1 branch November 15, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardLT WardLT WardLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uses deprecated yaml.load()
2 participants
@loriab @WardLT