Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename list_history to list_records #404

Merged
merged 2 commits into from Sep 19, 2019
Merged

Rename list_history to list_records #404

merged 2 commits into from Sep 19, 2019

Conversation

mattwelborn
Copy link
Contributor

@mattwelborn mattwelborn commented Sep 18, 2019 •
edited

Description

This PR renames Dataset.list_history to Dataset.list_records. It deprecates Dataset.list_history.

This PR is part of the ANI-1 Milestone:
image

Status

  • Changelog updated
  • Ready to go

@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited

Codecov Report

Merging #404 into master will increase coverage by 4.3%.
The diff coverage is 57.14%.

dgasmith
dgasmith approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgasmith
Copy link
Contributor

I like the graph!

@mattwelborn mattwelborn merged commit e8ce31c into MolSSI:master Sep 19, 2019
@mattwelborn mattwelborn deleted the list_records branch September 19, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgasmith dgasmith dgasmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattwelborn @dgasmith