Parsl QueueAdapter #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgasmith
added
Enhancement
|
This pull request introduces 1 alert when merging a8b542a into 03177f2 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
dgasmith
force-pushed
the
parsl
branch
2 times, most recently
from
56800c5
to
109a7ea
Compare
Lnaden
approved these changes
Oct 30, 2018
| @@ -973,7 +973,7 @@ def get_managers(self, query, projection=None): | |||
|
|
|||
| ### Users | |||
|
|
|||
| def add_user(self, username, password, permissions=["read"]): | |||
| def add_user(self, username, password, permissions=None): | |||
There was a problem hiding this comment.
If you did not want to set this to None just to make the kwarg default mutable, you could set a tuple as the default which would fix the issue. Not required though for this pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an initial Parsl QueueAdapter integration. Parsl is a pretty neat new workflow engine that is potentially extremely powerful for us as it has integrations to a large number of interfaces.
Status