Release 4.0.0 #141
Merged
Release 4.0.0 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGenheden
reviewed
Dec 5, 2023
SGenheden
reviewed
Dec 5, 2023
SGenheden
reviewed
Dec 5, 2023
|
The plugins folder is missing |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 80.02% 84.06% +4.04%
==========================================
Files 65 56 -9
Lines 4995 4676 -319
Branches 828 863 +35
==========================================
- Hits 3997 3931 -66
+ Misses 807 556 -251
+ Partials 191 189 -2 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 5, 2023
SGenheden
reviewed
Dec 5, 2023
aizynthfinder/search/mcts/state.py
Outdated
| @@ -51,13 +51,14 @@ def __init__(self, mols: Sequence[TreeMolecule], config: Configuration) -> None: | |||
| self.is_solved = all(self.in_stock_list) | |||
| self.max_transforms = max(mol.transform for mol in self.mols) | |||
| self.is_terminal = ( | |||
| self.max_transforms > config.max_transforms | |||
| self.max_transforms > config.search.max_transforms | |||
There was a problem hiding this comment.
This should be ">=" not ">"
SGenheden
approved these changes
Dec 5, 2023
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.