Correct a couple of the outstanding codacy issues.

Signed-off-by: Adrian.Conlon <adrian.conlon@gmail.com>
MoleskiCoder · Sep 11, 2017 · 5b145c4 · 5b145c4
1 parent a1f39de
commit 5b145c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/libs/libchip8/Configuration.cpp b/src/libs/libchip8/Configuration.cpp
@@ -62,7 +62,7 @@ void Configuration::read(std::string path) {
 	m_graphicsCountRowHits = reader.GetBooleanValue("Graphics.CountRowHits", m_graphicsCountRowHits);
 }
 
-ProcessorLevel Configuration::GetProcessorTypeValue(const ConfigurationReader& reader, std::string path, ProcessorLevel defaultValue) const {
+ProcessorLevel Configuration::GetProcessorTypeValue(const ConfigurationReader& reader, const std::string& path, ProcessorLevel defaultValue) const {
 
 	auto value = reader.GetStringValue(path);
 	if (value.empty())
@@ -77,6 +77,6 @@ ProcessorLevel Configuration::GetProcessorTypeValue(const ConfigurationReader& r
 	return ProcessorLevel::xoChip;
 }
 
-ProcessorLevel Configuration::GetProcessorTypeValue(const ConfigurationReader& reader, std::string path) const {
+ProcessorLevel Configuration::GetProcessorTypeValue(const ConfigurationReader& reader, const std::string& path) const {
 	return GetProcessorTypeValue(reader, path, ProcessorLevel::superChip);
 }
diff --git a/src/libs/libchip8/Configuration.h b/src/libs/libchip8/Configuration.h
@@ -205,6 +205,6 @@ class Configuration {
 	bool m_chip8LoadAndSave;
 	bool m_chip8IndexedJumps;
 
-	ProcessorLevel GetProcessorTypeValue(const ConfigurationReader& reader, std::string path, ProcessorLevel defaultValue) const;
-	ProcessorLevel GetProcessorTypeValue(const ConfigurationReader& reader, std::string path) const;
+	ProcessorLevel GetProcessorTypeValue(const ConfigurationReader& reader, const std::string& path, ProcessorLevel defaultValue) const;
+	ProcessorLevel GetProcessorTypeValue(const ConfigurationReader& reader, const std::string& path) const;
 };