Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FASTQ renaming through samples sheets is broken #18

Closed
serine opened this issue Feb 26, 2018 · 1 comment
Closed

FASTQ renaming through samples sheets is broken #18

serine opened this issue Feb 26, 2018 · 1 comment

Comments

@serine
Copy link
Collaborator

serine commented Feb 26, 2018

A sample sheet like this

old_prefix    new_prefix
1       wt_cond1_rep1
5       wt_cond1_rep2
2       wt_cond2_rep1
10      wt_cond2_rep2
7       mt_cond1_rep1
11      mt_cond1_rep2
9       mt_cond2_rep1
12      mt_cond2_rep2

will append samples 1,10,11 and 12 into single sample, because of this line, because all of those five different files start with 1.

I need to think about this problem, but I reckon I need to somehow check/assert that values of samplesMap are all of the same length. and/or somehow check that sample that has been assigned to a different key doesn't get repeated/re-assigned multiple times. Something like "seen" list. Before you put another fastq file into samplesMap check that it hasn't been "seen" and if it hasn't append into samplesMap and if it has raise an error? I guess.

So if anyone want to send a patch through will appreciate this. Otherwise some what lowerish priority, but should fix it this in the next couple of month.

serine added a commit that referenced this issue May 8, 2018
Using bubble sort in sikFqFiles.bds getSamplesMap function
@serine
Copy link
Collaborator Author

serine commented May 9, 2018

As per the commit this issue should be fixed now

@serine serine closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant