feat: return only public articles for restricted query #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutajdash
requested changes
Aug 23, 2022
| ({ publishStatus, isInstituteRestricted }) => | ||
| (_restritedPermission || !isInstituteRestricted) && (_unpublishedPermission || publishStatus) | ||
| ); | ||
| return publicArticles; |
There was a problem hiding this comment.
@120EE0692 please document the changes being made and the reasons behind them. Also, please add an error to the response so the frontend may know that not all articles were given.
rutajdash
approved these changes
Aug 26, 2022
rutajdash
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved or Linked Issues
Reference any and all issues solved and related to this pull request here. Mention if there are none.
Description and Changes
Please describe your pull request with all changes made.
Your checklist for this pull request
馃毃Please review the guidelines for contributing to this repository.
Post merge checklist