Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create User Schema #62

Merged
merged 75 commits into from
May 4, 2021
Merged

Create User Schema #62

merged 75 commits into from
May 4, 2021

Conversation

rutajdash
Copy link
Member

@rutajdash rutajdash commented Feb 19, 2021 •
edited

Solved or Linked Issues

Fixes #55

Description and Changes

  • Add User Type
  • Add User Resolver
  • Add User Query
  • Add User Mutation

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a work/topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the development (left side). Also you should start your branch off default branch and follow the branch naming guidelines.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation and mentioned the related issues (if appropriate)
  • I have added the appropriate labels, requested a review from a repository manager and assigned myself to this pull request.

Post merge checklist

@rutajdash rutajdash self-assigned this Feb 19, 2021
@rutajdash rutajdash added the wip Work in Progress label Feb 19, 2021
@DesignrKnight
Copy link
Member

Create user schema is a new feature, prefer not to add bugfix to this PR

@rutajdash
Copy link
Member Author

Create user schema is a new feature, prefer not to add bugfix to this PR

Alright, do I revert this commit?

@rutajdash rutajdash requested review from VishalR3 and DesignrKnight and removed request for VishalR3 April 6, 2021 11:32
@rutajdash
Copy link
Member Author

@DesignrKnight @VishalR3 review please

DesignrKnight
DesignrKnight reviewed Apr 9, 2021
View reviewed changes
.github/workflows/devDeploy.yml Show resolved Hide resolved
planning/v1/ROLES.md Show resolved Hide resolved
server/app.js Show resolved Hide resolved
server/package.json Show resolved Hide resolved
server/schema/user/user.model.js Show resolved Hide resolved
server/schema/user/user.resolver.js Outdated Show resolved Hide resolved
server/schema/user/user.resolver.js Outdated Show resolved Hide resolved
server/schema/user/user.resolver.js Show resolved Hide resolved
server/schema/user/user.resolver.js Show resolved Hide resolved
server/schema/user/user.resolver.js Show resolved Hide resolved
@rutajdash
Remove default field where unnecessary
e34c0c6
@rutajdash
Update resolvers
2eeb50b 
Use findById where possible; Add TODO were required;
@DesignrKnight
Copy link
Member

Seems like you have not seen this
https://firebase.google.com/docs/auth/web/account-linking

This was referenced May 3, 2021
Closed
Closed
@rutajdash
Copy link
Member Author

@DesignrKnight please approve, pending architectural changes will be done in future PRs. @VishalR3 please merge after approval.

@github-actions
Copy link

github-actions bot commented May 3, 2021

Prettier Response:

@VishalR3 VishalR3 merged commit 7ee97da into Monday-Morning:development May 4, 2021
@rutajdash rutajdash deleted the wip/graphql/user branch May 4, 2021 10:20
@rutajdash rutajdash added this to the Phase 1 Launch milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DesignrKnight DesignrKnight DesignrKnight approved these changes

Assignees

@rutajdash rutajdash

Labels
wip Work in Progress
Projects
None yet
Milestone
Phase 1 Launch
Development

Successfully merging this pull request may close these issues.

Create User Schema
3 participants
@rutajdash @DesignrKnight @VishalR3