Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add app recommender #398

Closed
wants to merge 5 commits into from
Closed

feat: add app recommender #398

wants to merge 5 commits into from

Conversation

Shurtu-gal
Copy link
Member

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Linked Issues

Fixes #397

Description

Screenshots :-

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@Shurtu-gal Shurtu-gal self-assigned this Jan 12, 2023
@Shurtu-gal Shurtu-gal added the enhancement New feature or request label Jan 12, 2023
120EE0692
120EE0692 requested changes Jan 16, 2023
View reviewed changes
client/src/components/marginals/Footer.js Outdated Show resolved Hide resolved
client/src/components/marginals/Footer.js Outdated Show resolved Hide resolved
120EE0692
120EE0692 requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@120EE0692 120EE0692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shurtu-gal run prettier in all files, in which you make changes.

rutajdash
rutajdash requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there any way to check if the user already has the app installed?

  2. Can we call on the app instead of a Play Store link? As far as I know, calling on an app to open in Android goes to the app or defaults to the same app's play store page. Find how it is done.

  3. We also need to check OS before showing this instead of browser type because it should only appear on Android for now.

client/src/assets/placeholder/appRecommender.js Outdated Show resolved Hide resolved
client/src/assets/placeholder/appRecommender.js Outdated Show resolved Hide resolved
client/src/assets/placeholder/appRecommender.js Show resolved Hide resolved
@rutajdash
Copy link
Member

Check this out -
https://stackoverflow.com/questions/2958701/launch-custom-android-application-from-android-browser

@Shurtu-gal
Copy link
Member Author

Currently, links to "https://mondaymorning.nitrkl.ac.in/article" are being redirected to the app.
But when it is not installed it is redirecting to the website.

@Shurtu-gal
Copy link
Member Author

Shurtu-gal commented Jan 23, 2023 •
edited
Loading

navigator.getInstalledRelatedApps() API can be used for checking if the app is installed.
It is supported on Chrome Android.
https://web.dev/get-installed-related-apps/
https://medium.com/dev-channel/detect-if-your-native-app-is-installed-from-your-web-site-2e690b7cb6fb

@rutajdash
Copy link
Member

navigator.getInstalledRelatedApps() API can be used for checking if the app is installed.
It is supported on Chrome Android.

@120EE0692
It would be good to implement this too I guess? Then we can call the app instead of going to playstore always.

@Shurtu-gal
Copy link
Member Author

@rutajdash @120EE0692 is this still needed? Else it can be closed I guess.

@120EE0692
Copy link
Member

@rutajdash @120EE0692 is this still needed? Else it can be closed I guess.

This is required.

@Shurtu-gal
Copy link
Member Author

Closing this as not-planned.

@Shurtu-gal Shurtu-gal closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rutajdash rutajdash rutajdash requested changes

@120EE0692 120EE0692 Awaiting requested review from 120EE0692

Assignees

@Shurtu-gal Shurtu-gal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add app recommender components
3 participants
@Shurtu-gal @rutajdash @120EE0692