COPY INTO FROM ON CLIENT #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is no longer called by mapi.Connection.cmd().
Before we returned 0 but that leads to endless loops when called by the utf-8 codec.
They are very useful.
instead of calling codecs.getreader(). This allows us to force the line endings to "\n"
So a class can implement Uploader and Downloader simultaneously
gijzelaerr
requested changes
Apr 5, 2022
pymonetdb/filetransfer.py
Outdated
| mapi._putblock(f"Invalid file transfer command: {cmd!r}") | ||
|
|
||
|
|
||
| def handle_upload(mapi, filename, text_mode, offset): |
There was a problem hiding this comment.
missing type annotations
There was a problem hiding this comment.
Ok, I've added a whole bunch of additional type annotations.
Not easy because the IO types don't type annotate well.
In particular, for some reason a BufferedIOBase is not accepted as an IO[bytes].
There was a problem hiding this comment.
interesting, is this with all python versions?
|
I just had a quick scan of the code, first impression is that It looks good, but i need to look better at the logic at some point. My first biggest comment is:
|
gijzelaerr
approved these changes
Apr 12, 2022
|
|
||
| from io import BufferedIOBase, BufferedWriter, RawIOBase, TextIOBase, TextIOWrapper | ||
| from typing import Any, Optional, Union | ||
| from pymonetdb import mapi as mapi_protocol |
There was a problem hiding this comment.
why not just do from pymonetdb.mapi import Connection and use that as type?
There was a problem hiding this comment.
It gave circular import problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is not finished but I'm creating the pull request so you can keep an eye on it and make suggestions, and also to benefit from the CI. The idea is to add support for ON CLIENT. For example:
With ON CLIENT, the server does not open the the file by itself but sends a request to pymonetdb to open it on its behalf. The client opens the file and reads it, or makes up some data on the spot, and sends it to the server which processes it as usual.
ON CLIENT is useful to avoid having to first copy data to a location on the server accessible both to the user and the server, and for side stepping all sorts of permissions problems. Mclient has supported it for quite a while and recently I added support to monetdb-jdbc. Now I would like to add support for it to pymonetdb.