Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single node replica set option to enable transactions #57

Merged
merged 12 commits into from
Oct 12, 2018

Conversation

mahisatyanarayana
Copy link
Contributor

Added option to spin up mongod as a single node replica set so transactions could be enabled.

…rorOutput are assigned correctly

2. Connecting to the server to initiate the replicaSet
…we need to connect to the primary in order to initiate the repl set

1. Updated the drivers to 2.7.0 (why didn't I do this two days ago?)
2. If mongo2go is started with  singleNodeReplSet flag equals to true then the MongoDbProcessStarter will spin up and INITIATE a replica set
3. All tests are passing at this moment
…lica set

2. Use the port variable to build replica set config
3. Update nuspec with pre-release tag for local testing
4. Update README.md with correct binary version
2. Set readPreference to "primary" in the uri while connecting to a replica set
3. Sleep the thread for 5 seconds right after sending replSetInitiate command so replica set has time to finish initiating
@JohannesHoppe
Copy link
Member

JohannesHoppe commented Sep 26, 2018

This looks like some excellent work. Could you please document this feature?
E.g. a new part in the README with a short introduction and a sample, how to leverage transactions?

@mahisatyanarayana
Copy link
Contributor Author

I will update the README document. Thank you!

@mahisatyanarayana
Copy link
Contributor Author

mahisatyanarayana commented Sep 27, 2018

@JohannesHoppe - I have updated the README. Please let me know if you have any questions, comments or concerns.

P.S. Also took the liberty to modify the changelog section. Please feel free to update/modify it.

Thank you,
Mahi

@JohannesHoppe
Copy link
Member

This is how a PR should look like. I will review everything early next week.

@mahisatyanarayana
Copy link
Contributor Author

Hey @JohannesHoppe - Just following up to see if you had a chance to look at the pr.

Thank you,
Mahi

@fauxcoding
Copy link

Nice work @gbackmania. Its a great feeling looking for a feature in an OSS library and finding a PR delivering it!

@JohannesHoppe JohannesHoppe merged commit 1293068 into Mongo2Go:master Oct 12, 2018
@JohannesHoppe
Copy link
Member

v2.2.8 is out, many thanks! 👍

@mahisatyanarayana
Copy link
Contributor Author

Thank you @JohannesHoppe. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants