Fixes a file path issue on Linux if you run on an sdk version beyond netstandard1.6 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohannesHoppe Is there anything you'd like to see added/changed about the PR? |
|
I'm sorry, I did not had some time to review this. I promise to do that soon! 👍 |
JohannesHoppe
added a commit
that referenced
this pull request
Feb 4, 2019
* fixes a file path issue on Linux if you run on an SDK version beyond .NET Standard 1.6 (PR #63, fixes #62, fixes #61) many thanks to @Vannevelj
|
Test runs successful on my mac, too |
|
The package Mongo2Go 2.2.9 was recently published on NuGet Gallery. Many thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #62 using the solution provided in #61. @alexfowler09 was correct with his suggestion -- after applying the suggested changes, Linux worked both on my VM as well as my build server.
I'm unclear what changed inside the SDK to make it suddenly work. So far I haven't been able to pinpoint anything aside from the fact that it seemingly doesn't resolve the
~as a relative path insideDirectory.GetDirectories(path)and I'm unsure if this is a regression. Seeing as Mongo2Go points to netstandard1.6, it seems like it potentially is a change between netcore1.0 and netcore1.1/2.0. I'll give this further investigation but at least the most pressing issue is resolved.It doesn't seem unreasonable that the Mac lookups might require similar changes but since I don't own a Mac, I can't try it out to verify. Will leave it as-is, I guess you'll see if someone complains about something similar.