Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect parameter #321

Merged
2 commits merged into from Jan 10, 2018
Merged

Connect parameter #321

2 commits merged into from Jan 10, 2018

Conversation

noirbizarre
Copy link
Collaborator

This PR allows to use MONGODB_CONNECT parameter and document both the existing MONGO_SETTINGS['connect'] and the new MONGODB_CONNECT parameters.

I had to read #255 to discover this possibility which isn't documented and this solve a common issue.

Context: this feature seems to appear in #280 but there was issues and PRs before. ex: #255, #266, #126

This PR allows to declare a lazy connection with `MONGODB_CONNECT = False` because right now only the `MONGODB_SETTINGS` dict support this parameter
@patvdleer
Copy link

Please complete this merge request, the Travis errors seem to be total BS, i.e. pip and PyPy3 related

@noirbizarre
Copy link
Collaborator Author

Any news on this one ?
Tests are passing except those on Pypy3 which werealready failing before.

@noirbizarre
Copy link
Collaborator Author

@touilleMan @rozza @wojcikstefan
Sorry to ping you, but this issue is really blocking and I just want to know how I can help to get this merged, what should I change if it's needed... (build errors are totally unrelated to this PR)

@lafrech
Copy link
Member

lafrech commented Jan 8, 2018

Looks good to me. Care to add a test in https://github.com/MongoEngine/flask-mongoengine/blob/master/tests/test_connection.py#L169?

Indeed, the CI failure is unrelated (I relaunched the tests for latest commit in master in got the same errors).

I'm not involved in flask-mongoengine anymore as I'm using @touilleMan's umongo. @rozza isn't involed anymore either AFAIK.

@noirbizarre, I can give you write access if you want to help maintaining flask-mongoengine. @MongoEngine/flask-mongoengine, any objection?

@touilleMan
Copy link
Member

@lafrech that's fine for me ;-)

(you should give @noirbizarre write right to the whole mongoengine organisation if you can)

@ghost ghost merged commit 47d265b into MongoEngine:master Jan 10, 2018
@noirbizarre noirbizarre deleted the connect-parameter branch January 12, 2018 10:47
@noirbizarre
Copy link
Collaborator Author

Thanks !

I'm using mongoengine on only one project now, but it's an important project.

I also switched on umongo on my other projets 😉 Glad to see that's the same team.
If you give me write access I can perform so basic maintainance (ie. review, merge and release) on flask-mongoengine but not much more because I also have other projects to maintain and as you know it's time consuming !

@lafrech
Copy link
Member

lafrech commented Jan 12, 2018

@noirbizarre, I can't invite you to the organization. I invited you to be a collaborator on both Mongoengine and flask-mongoengine. No pressure to do any work.

@touilleMan
Copy link
Member

@noirbizarre Happy to hear you find umongo useful ;-)
If you want I can give you write access to umongo repo 😄

@noirbizarre
Copy link
Collaborator Author

Yes, great ! I'll be glad to help on umongo too (I'll have some patches to submit and I'm working on a factory module for umongo aka. a factoryboy-like but async)

@touilleMan
Copy link
Member

@noirbizarre welcome aboard 🎉

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants