Fix for inheritance bug and db_alias

MongoEngine · Jul 20, 2012 · 3070e0b · 3070e0b
1 parent 83c11a9
commit 3070e0b
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 11 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -2,9 +2,14 @@
 Changelog
 =========
 
+
+Changes in 0.6.16
+=================
+- Fixed issue where db_alias wasn't inherited
+
 Changes in 0.6.15
 =================
-- Updated validation error message
+- Updated validation error messages
 - Added support for null / zero / false values in item_frequencies
 - Fixed cascade save edge case
 - Fixed geo index creation through reference fields

diff --git a/mongoengine/__init__.py b/mongoengine/__init__.py
@@ -12,7 +12,7 @@
 __all__ = (document.__all__ + fields.__all__ + connection.__all__ +
            queryset.__all__ + signals.__all__)
 
-VERSION = (0, 6, 15)
+VERSION = (0, 6, 16)
 
 
 def get_version():

diff --git a/mongoengine/base.py b/mongoengine/base.py
@@ -649,8 +649,13 @@ def __new__(cls, name, bases, attrs):
                     del(attrs['meta']['collection'])
                 if base._get_collection_name():
                     collection = base._get_collection_name()
-                # Propagate index options.
-                for key in ('index_background', 'index_drop_dups', 'index_opts'):
+
+                # Propagate inherited values
+                keys_to_propogate = (
+                    'index_background', 'index_drop_dups', 'index_opts',
+                    'allow_inheritance', 'queryset_class', 'db_alias',
+                )
+                for key in keys_to_propogate:
                     if key in base._meta:
                         base_meta[key] = base._meta[key]
 
@@ -659,18 +664,14 @@ def __new__(cls, name, bases, attrs):
                     abstract_base_indexes += base._meta.get('indexes', [])
                 else:
                     base_indexes += base._meta.get('indexes', [])
-                # Propagate 'allow_inheritance'
-                if 'allow_inheritance' in base._meta:
-                    base_meta['allow_inheritance'] = base._meta['allow_inheritance']
-                if 'queryset_class' in base._meta:
-                    base_meta['queryset_class'] = base._meta['queryset_class']
             try:
                 base_meta['objects'] = base.__getattribute__(base, 'objects')
             except TypeError:
                 pass
             except AttributeError:
                 pass
 
+        # defaults
         meta = {
             'abstract': False,
             'collection': collection,

diff --git a/python-mongoengine.spec b/python-mongoengine.spec
@@ -5,7 +5,7 @@
 %define srcname mongoengine
 
 Name:           python-%{srcname}
-Version:        0.6.15
+Version:        0.6.16
 Release:        1%{?dist}
 Summary:        A Python Document-Object Mapper for working with MongoDB
 

diff --git a/tests/test_document.py b/tests/test_document.py
@@ -2999,7 +2999,7 @@ class Book(Document):
         self.assertEqual(User.objects.first(), bob)
         self.assertEqual(Book.objects.first(), hp)
 
-        # DeRefecence
+        # DeReference
         class AuthorBooks(Document):
             author = ReferenceField(User)
             book = ReferenceField(Book)
@@ -3027,6 +3027,18 @@ class AuthorBooks(Document):
         self.assertEqual(Book._get_collection(), get_db("testdb-2")[Book._get_collection_name()])
         self.assertEqual(AuthorBooks._get_collection(), get_db("testdb-3")[AuthorBooks._get_collection_name()])
 
+    def test_db_alias_propagates(self):
+        """db_alias propagates?
+        """
+        class A(Document):
+            name = StringField()
+            meta = {"db_alias": "testdb-1", "allow_inheritance": True}
+
+        class B(A):
+            pass
+
+        self.assertEquals('testdb-1', B._meta.get('db_alias'))
+
     def test_db_ref_usage(self):
         """ DB Ref usage in __raw__ queries """