Merge pull request #879 from DavidBord/fix-866

Fix #866: does not follow
MongoEngine · Feb 16, 2015 · aca8899 · aca8899
2 parents 0205d82 + 5c3d91e
commit aca8899
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -5,6 +5,7 @@ Changelog
 
 Changes in 0.9.X - DEV
 ======================
+- `BaseDict` does not follow `setdefault` #866
 - Add support for $type operator # 766
 - Fix tests for pymongo 2.8+ #877
 - No module named 'django.utils.importlib' (Django dev) #872

diff --git a/mongoengine/base/datastructures.py b/mongoengine/base/datastructures.py
@@ -75,6 +75,10 @@ def popitem(self, *args, **kwargs):
         self._mark_as_changed()
         return super(BaseDict, self).popitem(*args, **kwargs)
 
+    def setdefault(self, *args, **kwargs):
+        self._mark_as_changed()
+        return super(BaseDict, self).setdefault(*args, **kwargs)
+
     def update(self, *args, **kwargs):
         self._mark_as_changed()
         return super(BaseDict, self).update(*args, **kwargs)

diff --git a/tests/fields/fields.py b/tests/fields/fields.py
@@ -1176,6 +1176,11 @@ class BlogPost(Document):
         post.reload()
         self.assertEqual('updated', post.info['title'])
 
+        post.info.setdefault('authors', [])
+        post.save()
+        post.reload()
+        self.assertEqual([], post.info['authors'])
+
         BlogPost.drop_collection()
 
     def test_dictfield_strict(self):