Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency specifier to allow pymongo 4.x #2630

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

terencehonles
Copy link
Contributor

I noticed this was missed in 0.24.0 as installing via pip-tools which is checking the version constraints.

setup.py Outdated Show resolved Hide resolved
@bagerard
Copy link
Collaborator

bagerard commented Mar 6, 2022

Thanks for the contribution 👍

@bagerard bagerard merged commit 23ab63c into MongoEngine:master Mar 7, 2022
@terencehonles terencehonles deleted the allow-pymongo-4.x branch March 7, 2022 21:23
@bagerard
Copy link
Collaborator

bagerard commented Mar 9, 2022

btw @terencehonles, throwing this here just in case but if you might be interested to help on maintaining this project, please let me know. Additional help wouldn't harm :)

@terencehonles
Copy link
Contributor Author

btw @terencehonles, throwing this here just in case but if you might be interested to help on maintaining this project, please let me know. Additional help wouldn't harm :)

Thanks for the offer, I'll consider it, but for the time being I probably should try to remain a contributor until I have a better idea about my bandwidth and if I can offer any support reviewing PRs.

@bagerard
Copy link
Collaborator

Sounds fair 👍

@23pointsNorth
Copy link

This PR fixes #2624.
Any idea if there'll be a patch version in pypi with this?

@bagerard
Copy link
Collaborator

Good point, I'll trigger one tonight

@bagerard
Copy link
Collaborator

FYI 0.24.1 got released a few minutes ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants