Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use deprecated property for emptiness check #2633

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Don't use deprecated property for emptiness check #2633

merged 2 commits into from
Mar 11, 2022

Conversation

arthurio
Copy link
Contributor

@arthurio arthurio commented Mar 8, 2022 •
edited

Why?

The current check in https://github.com/mongoengine/mongoengine/blob/master/mongoengine/queryset/base.py#L725 uses the deprecated empty property.

arthurio
arthurio commented Mar 8, 2022
View reviewed changes
mongoengine/queryset/base.py Outdated Show resolved Hide resolved
@arthurio arthurio marked this pull request as ready for review March 8, 2022 01:45
bagerard
bagerard requested changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@bagerard bagerard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, only one minor comment to address and it will be good to go 👍

@bagerard bagerard merged commit dd17d73 into MongoEngine:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagerard bagerard bagerard requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arthurio @bagerard