New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complex field #924

Closed

Catstyle wants to merge 2 commits into MongoEngine:master from Catstyle:feature/complex_field_issue

Contributor

Catstyle commented Apr 1, 2015

1 do not mark complex field as changed when parse from son
2 change DynamicField to subclass from ComplexField

1: since no data actually store in db, then no need to append it to changed_fields, otherwise when call save method without changes, they will appear in removals set unnecessarily
2: as metioned: #889 (comment)


          do not mark complex field as changed when parse from son; change Dyna…

…micField to subclass from ComplexField

landscape-bot commented Apr 1, 2015

Repository health increased by 0.11% when pulling 5573080 on Catstyle:feature/complex_field_issue into cbd2a44 on MongoEngine:master.

1 new problem was found (including 0 errors and 1 code smell).
19 problems were fixed (including 0 errors and 19 code smells).

coveralls commented Apr 1, 2015

Changes Unknown when pulling 5573080 on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.


          fix assign doc value to dynamic field

fd4ae6a

landscape-bot commented Apr 1, 2015

Repository health increased by 0.11% when pulling fd4ae6a on Catstyle:feature/complex_field_issue into cbd2a44 on MongoEngine:master.

1 new problem was found (including 0 errors and 1 code smell).
19 problems were fixed (including 0 errors and 19 code smells).

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

7 similar comments

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

coveralls commented Apr 1, 2015

Changes Unknown when pulling fd4ae6a on Catstyle:feature/complex_field_issue into * on MongoEngine:master*.

Member

MRigal commented Apr 3, 2015

Please add one or two test cases here. I think you could build one quite easily out of the issue

MRigal added the Awaiting Response label

landscape-bot commented May 6, 2015

Repository health decreased by 0.26% when pulling fd4ae6a on Catstyle:feature/complex_field_issue into 7f442f7 on MongoEngine:master.

36 new problems were found (including 3 errors and 30 code smells).
8 problems were fixed (including 0 errors and 8 code smells).

Collaborator

bagerard commented Jan 1, 2023

Closing as very old and unclear what the problem is or if it still exist (no test case)

bagerard closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment