Fix non-lowercase words handling in Hangman #10098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Currently hangman only works with lowercase letters as guesses are only accepted as single ASCII lowercase letters and current logic is case-sensitive. This PR adds support for non-lowercase words with full proper handling.
Summary
Recently, I've seen one of the users ask (MAS Discord) why their hangman word was not guessed, even if they tried the letters correctly. They tried to guess the letter
v, but their word (apparently, because of using German translation with translated word list where a titlecased word was found with uppercaseV) had it in uppercase and the game didn't take the guess as correct:This PR resolves this issue and additionally, adds support for non-lowercase words that are handled properly and displayed properly (without forcing them lowercase):