Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for LOOPSTART and LOOPLENGTH tags #1695

Merged

Conversation

ThePotatoGuy
Copy link
Member

#1670 #1657

Okay @williamjcm , are you satisfied now? (jk, no animosity here, in case it wasn't obvious)

This changes the tags introduced in #1670 to be masloopstart and masloopend, and adds support for the RPGMaker tags LOOPSTART LOOPLENGTH (which are samples instead of the superior seconds).

LOOPSTART and LOOPLENGTH tags only work for OGG/VORBIS files

Looping instructions:

MAS-style:

  1. Open audio file in audacity
  2. Export as OGG / OPUS and edit metadata
  3. Add a tag for masloopstart and specify the timestamp (in seconds) where to start the loop.
  4. Add a tag for masloopend and specify the timestamp (in seconds) where to end the loop.
  5. Put audio file in custom_bgm/ folder.

RPGMaker-style:

  1. Open audio file in audacity
  2. Export as OGG and edit metadata
  3. Add a tag for loopstart and specify the number of samples where to start the loop.
  4. Add a tag for looplength and specify the number of samples for how long the loop should last.
  5. Put audio file in custom_bgm/ folder.

NOTE:

  • all tags are case-insensitive
  • MAS-style tags are preferred over RPGMaker-style tags

@ThePotatoGuy ThePotatoGuy added awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Jun 2, 2018
@aldoram5 aldoram5 removed awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested labels Jun 3, 2018
@ThePotatoGuy ThePotatoGuy merged commit 2e38f82 into Monika-After-Story:enhancement Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants