Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rework] - Anniversary 5 #8572

Merged
merged 7 commits into from
Jan 23, 2022
Merged

[Rework] - Anniversary 5 #8572

merged 7 commits into from
Jan 23, 2022

Conversation

lunulae
Copy link
Contributor

@lunulae lunulae commented Jan 8, 2022

#8041 ❤️

I wanted to keep the first line mostly the same, but most of the rest of it is altered.
Might need a little polish on the exps? I'm not sure.

@multimokia multimokia self-requested a review January 15, 2022 21:10
@multimokia multimokia added awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested labels Jan 15, 2022
@multimokia multimokia added this to the Next Release milestone Jan 15, 2022
multimokia
multimokia requested changes Jan 15, 2022
View reviewed changes
Copy link
Member

@multimokia multimokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions on slightly diff exps and tiny phrasing things, feel free to modify as you see fit

Monika After Story/game/script-anniversary.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-anniversary.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-anniversary.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-anniversary.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-anniversary.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-anniversary.rpy Outdated Show resolved Hide resolved
lunulae and others added 4 commits January 22, 2022 15:24
@lunulae @multimokia
much better exps and flow, thank you multi :D
ebbcfdb 
Co-authored-by: multimokia <multimokia3@gmail.com>
@lunulae @multimokia
whoops, I missed one
1147e08 
Co-authored-by: multimokia <multimokia3@gmail.com>
@jmwall24
edits
0bc231e
@multimokia
fpyo
0635ee9
@multimokia multimokia self-requested a review January 23, 2022 02:51
@jmwall24 jmwall24 added this to awaiting review in topic issues via automation Jan 23, 2022
topic issues automation moved this from awaiting review to awaiting merge Jan 23, 2022
@jmwall24 jmwall24 removed awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Jan 23, 2022
@jmwall24 jmwall24 merged commit be5815d into content Jan 23, 2022
topic issues automation moved this from awaiting merge to done Jan 23, 2022
@multimokia multimokia deleted the anni5 branch January 23, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multimokia multimokia multimokia approved these changes

@jmwall24 jmwall24 jmwall24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
topic issues
  
done
Milestone
v0.12.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lunulae @multimokia @jmwall24