Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder-based hair and ACS sprites #9619

Open
wants to merge 8 commits into
base: content
Choose a base branch
from

Conversation

ThePotatoGuy
Copy link
Member

@ThePotatoGuy ThePotatoGuy commented Sep 25, 2022

#8596

Key Changes

  • hair and ACS sprite objects now support folder-based organization, basically similar to clothes:
    • h/<hair name>/front.png or h/<hair name>/0.png
    • a/<acs name>/0.png
  • sprite JSONs support the new format as well
  • a simple bash script for renaming using git is provided, but a full-fledged spritepack updater will be added in spack updates part 2 #9729

Testing

  • verify that all current sprites load correctly
  • verify spritepacks with jsons do not break - testing of the new json props should be in spack updates part 2 #9729 for ease of testing

@ThePotatoGuy ThePotatoGuy added awaiting testing code needs to be tested DONT MERGE srs awaiting code review someone needs to check for syntax/logic/indentation errors labels Sep 25, 2022
@ThePotatoGuy ThePotatoGuy added this to the 0.12.12 milestone Sep 25, 2022
@ThePotatoGuy ThePotatoGuy added this to awaiting review in core via automation Sep 25, 2022
@ThePotatoGuy ThePotatoGuy marked this pull request as draft September 25, 2022 04:36
@ThePotatoGuy ThePotatoGuy linked an issue Sep 25, 2022 that may be closed by this pull request
@jmwall24 jmwall24 modified the milestones: 0.12.12, 0.13.0 Oct 22, 2022
@ThePotatoGuy ThePotatoGuy modified the milestones: 0.13.0, 0.12.13 Nov 10, 2022
@ThePotatoGuy ThePotatoGuy marked this pull request as ready for review November 10, 2022 02:25
@ThePotatoGuy ThePotatoGuy removed the DONT MERGE srs label Nov 10, 2022
@ThePotatoGuy ThePotatoGuy modified the milestones: 0.12.13, ? 0.12.14 Dec 18, 2022
@Booplicate Booplicate mentioned this pull request Jan 23, 2023
@ThePotatoGuy ThePotatoGuy modified the milestones: ? 0.12.14, ? 0.12.15 Feb 12, 2023
@Booplicate Booplicate modified the milestones: 0.12.15, 0.12.16 Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested
Projects
core
  
awaiting review
Development

Successfully merging this pull request may close these issues.

sprite system folder-based organization
3 participants