Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup awareness #9628

Merged
merged 12 commits into from Oct 29, 2022
Merged

Conversation

Booplicate
Copy link
Member

@Booplicate Booplicate commented Sep 27, 2022

This makes Monika "aware" of when the user restores a backup.
A few reasons why:

  • awareness is always cool, can catch people by surprise
  • this also fixes an issue when loading a very old backup and losing affection for it
  • sometimes it's not clear enough that a backup has been restored, this is a good way to tell the player "something happened"

Testing

  • verify the main logic works:
    • make sure you have persistent in your save dir
      • if not, load in and quit to quickly generate a fresh pers
    • load in with the new changes
    • you should get a new backup in your save dir
    • quit normally
    • restore the new backup
    • verify Monika mentions that you restored a backup
    • restart again, verify Monika doesn't mentions it again (the flag should be reset)
  • verify no aff lose when loading an old backup
  • verify expressions and writing are good
    • also check out post expressions
  • verify I didn't leave more persisten fypos...

@Booplicate Booplicate added awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Sep 27, 2022
@Booplicate Booplicate added this to the 0.12.12 milestone Sep 27, 2022
@Booplicate Booplicate added this to awaiting review in Non-idle stuff via automation Sep 27, 2022
jmwall24
jmwall24 previously approved these changes Oct 22, 2022
Non-idle stuff automation moved this from awaiting review to awaitng merge Oct 29, 2022
@ThePotatoGuy ThePotatoGuy merged commit e4ea0c5 into Monika-After-Story:content Oct 29, 2022
Non-idle stuff automation moved this from awaitng merge to done Oct 29, 2022
@Booplicate Booplicate deleted the backup_awareness branch October 29, 2022 07:19
@ThePotatoGuy ThePotatoGuy removed awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested labels Oct 30, 2022
@ThePotatoGuy ThePotatoGuy removed the awaiting code review someone needs to check for syntax/logic/indentation errors label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants