Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback a dialogue in monika_portraitof to implement #9637 #9642

Merged
merged 5 commits into from Oct 15, 2022
Merged

Rollback a dialogue in monika_portraitof to implement #9637 #9642

merged 5 commits into from Oct 15, 2022

Conversation

dreamscached
Copy link
Member

This PR implements #9637. I made:

  • A rollback (sort of; this isn't using renpy rollback features but is made with {fast} and related {w}/{nw})
  • Added Yuri glitch (might be removed if deemed unnecessary, but imo this would look good and well combined with this topic 'amnesia')
  • Locked the event and derandomed so it doesn't show in 'Repeat topic' as if player literally forgot it

@dreamscached dreamscached changed the base branch from master to content October 3, 2022 07:40
Booplicate
Booplicate requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@Booplicate Booplicate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a topic from DDLC, let's not do unnecessary changes. Also Yuri jumpscare already exists in this form, we'd be just repeating ourselves.
That mas_hideEVL call is redundant since we already derandom the event.

@Booplicate Booplicate added awaiting testing code needs to be tested awaiting changes the pull request creator needs to make some changes awaiting code review someone needs to check for syntax/logic/indentation errors labels Oct 3, 2022
@Booplicate Booplicate added this to awaiting review in topic issues via automation Oct 3, 2022
@Booplicate Booplicate added this to the 0.12.12 milestone Oct 3, 2022
@Booplicate Booplicate linked an issue Oct 3, 2022 that may be closed by this pull request
[Suggestion] - Easter-egg. "Forget" a conversation. #9637
Closed
@Booplicate Booplicate removed the awaiting changes the pull request creator needs to make some changes label Oct 7, 2022
topic issues automation moved this from awaiting review to awaiting merge Oct 15, 2022
@jmwall24 jmwall24 removed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Oct 15, 2022
@jmwall24 jmwall24 merged commit 4aea728 into Monika-After-Story:content Oct 15, 2022
topic issues automation moved this from awaiting merge to done Oct 15, 2022
@dreamscached dreamscached deleted the issue-9637-impl branch October 16, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwall24 jmwall24 jmwall24 approved these changes

@Booplicate Booplicate Booplicate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
topic issues
  
done
Milestone
0.12.12
Development

Successfully merging this pull request may close these issues.

[Suggestion] - Easter-egg. "Forget" a conversation.
3 participants
@dreamscached @jmwall24 @Booplicate