New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to the island event #9689
Merged
ThePotatoGuy
merged 49 commits into
Monika-After-Story:content
from
Booplicate:isld_final
Oct 29, 2022
Merged
Additions to the island event #9689
ThePotatoGuy
merged 49 commits into
Monika-After-Story:content
from
Booplicate:isld_final
Oct 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new type of images - interior allow to directly specify the filenames of the images to load added the new images definitions some cleanup
add our cool custom table/char/shadow to the cache during init, that way we can use our dynamic displayables. Cool Co-Authored-By: ThePotatoGuy <potato@desu.zone>
have fun with easter eggs
Otherwise it assumes the images are on disk. Since renpy doesn't handle str being used as img tag in this case
This will add proper filters to both of the bgs
`decode_images` > `decode_data` improve unlock callbacks
- don't suggest to select current bg (it's pointless) - cleanup duplicated code using predicate lambdas to filter bgs - use def bg as a fallback if we somehow get to the selector with no bg available
Co-Authored-By: lunulae <45501964+lunulae@users.noreply.github.com>
Booplicate
added
awaiting dlg review
dialogue needs to be reviewed
awaiting testing
code needs to be tested
awaiting code review
someone needs to check for syntax/logic/indentation errors
labels
Oct 27, 2022
jmwall24
approved these changes
Oct 28, 2022
Legendkiller21
approved these changes
Oct 28, 2022
ThePotatoGuy
approved these changes
Oct 29, 2022
ThePotatoGuy
removed
awaiting dlg review
dialogue needs to be reviewed
awaiting testing
code needs to be tested
awaiting code review
someone needs to check for syntax/logic/indentation errors
labels
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions:
MASAudioData
- isn't used as of now, but will be used later for the next wave of changesChanges:
play_song
is deprecated in favour ofmas_play_song
getBackground
unlockBackground
lockBackground
isBackgroundUnlocked
mas_getCurrentBackgroundId
mas_isBackgroundUnlocked
Fixes:
_mfwm_find_fb_def
Recognition:
Testing: