Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sound feedback #91

Merged
merged 1 commit into from
May 16, 2019
Merged

Add sound feedback #91

merged 1 commit into from
May 16, 2019

Conversation

the0neyouseek
Copy link
Member

See #84

@the0neyouseek
🔊 Add sound when changing volume
fe88672 
Close #84
The system sound is played only when "Play feedback when volume is changed" in Sound Preferences is enabled
@the0neyouseek the0neyouseek added the Type: Enhancement Issue is an app enhancement label May 15, 2019
JoniVR
JoniVR approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@JoniVR JoniVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes a few seconds for the setting to update for me once I enable/disable but it works great 👍😁

@the0neyouseek the0neyouseek merged commit e955d84 into master May 16, 2019
@the0neyouseek the0neyouseek deleted the soundfeedback branch May 16, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoniVR JoniVR JoniVR approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Issue is an app enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@the0neyouseek @JoniVR