Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android 2.3.0 ceased to explode aars, PMD / Findbugs have incomplete auxclasspaths #17

Closed
jsotuyod opened this issue Jun 19, 2017 · 4 comments
Closed

Android 2.3.0 ceased to explode aars, PMD / Findbugs have incomplete auxclasspaths #17

jsotuyod opened this issue Jun 19, 2017 · 4 comments
Assignees
@jsotuyod
Labels
bug

Comments

@jsotuyod
Copy link
Member

As stated here: pmd/pmd#441 /cc @fciancio

Since Android plugin 2.3.0 the build/intermediates/exploded-aars/ directory is no more. Android seems to be using the aars directly nowadays, meaning we can't take the jars from there ourselves.

We may have to check the used version, and manually explode the aars ourselves...
@jsotuyod jsotuyod added the bug label Jun 19, 2017
@jsotuyod jsotuyod self-assigned this Jun 19, 2017
@jsotuyod
Copy link
Member Author

Disabling build-cache works. It should be possible to take the exploded aar from the cache, but requires:

  • detecting build cache is being used
  • detecting the location of the cache
  • finding the cache entry for the exploded aar for each aar

jsotuyod added a commit that referenced this issue Jun 20, 2017
@jsotuyod
Add failing test for #17
1e37dfc
jsotuyod added a commit that referenced this issue Jun 20, 2017
@jsotuyod
Fix #17
23d39ac 
 - When build-cache is active, point to the proper location for the
exploded-aar within the cache instead of looking for non-existing
folders
@jsotuyod
Copy link
Member Author

Fixed on develop. Should be part of next release (2.5.0). I still want to test in depth in multi-module scenarios. It's working, but I'm not completely sure it should...

@jsotuyod
Copy link
Member Author

jsotuyod commented Jun 21, 2017 •
edited

Confirmed, it's also failing for multimodule projects, I have a failing test scenario, I'll be working on a fix for that too soon.

@jsotuyod
Copy link
Member Author

Multi-module case fixed on development branch too. To be part of version 2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsotuyod jsotuyod

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsotuyod