-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isthisamap #1309
Isthisamap #1309
Conversation
The non main map files should be in the ~monkestation directory |
dont wanna add custom code for the shuttles and modules should be kept next to the main map for clarity sake as they are unique to that map |
/obj/item/kirbyplants/random/dead | ||
icon_state = "plant-25" | ||
|
||
/obj/structure/broken_flooring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being added here, also the pirates PR also ports the PR that refactors these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because its not the full pr its a stopgap until the actual pr is added
target.update_appearance() | ||
qdel(src) | ||
|
||
/obj/effect/mapping_helpers/broken_machine/proc/payload(obj/machinery/airalarm/target) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/obj/effect/mapping_helpers/broken_machine/proc/payload(obj/machinery/airalarm/target) | |
/obj/effect/mapping_helpers/broken_machine/proc/payload(obj/machinery/target) |
also im not sure this needs the /proc/
here, if it does then it should be moved up to parent so the same proc type can be used for this and the other helpers
return INITIALIZE_HINT_LATELOAD | ||
|
||
/obj/effect/mapping_helpers/requests_console/LateInitialize(mapload) | ||
var/obj/machinery/airalarm/target = locate(/obj/machinery/requests_console) in loc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var/obj/machinery/airalarm/target = locate(/obj/machinery/requests_console) in loc | |
var/obj/machinery/target = locate(/obj/machinery/requests_console) in loc |
@@ -0,0 +1,26 @@ | |||
/obj/item/book/granter/magazine/ | |||
icon = 'monkestation/code/modules/biodome/icons/magazine.dmi' | |||
icon_state = "mothboys" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😳
. = ..() | ||
random_colour() | ||
set_greyscale(new_config=/datum/greyscale_config/amoung) | ||
ADD_TRAIT(src, TRAIT_VENTCRAWLER_ALWAYS, INNATE_TRAIT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RED SUS
mob_type = /mob/living/basic/amoung/pequeno | ||
|
||
// amoung... surgeon?? | ||
// Can probably be replaced when I do my future 'among us content expansion', if that ever happens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The horror
## About The Pull Request Fixes starting the tgui dev server on Windows machines. Currently on Windows when starting the tgui dev server, it will be unable to find the Byond cache at any of the predefined paths it searches, and resort to using the registry even if one of the predefined paths should successfully locate it. Then, it will fail to find the tmp# folder inside that cache folder even if it exists. The reason is that on Windows, the glob package requires forward slashes when you call its methods such as sync(), as documented in the glob module's documentation: >Note Glob patterns should always use / as a path separator, even on Windows systems, as \ is used to escape glob characters. If you wish to use \ as a path separator instead of using it as an escape character on Windows platforms, you may set windowsPathsNoEscape:true in the options. In this mode, special glob characters cannot be escaped, making it impossible to match a literal * ? and so on in filenames. The function being used to assemble the path, node's path.resolve(), uses backslashes if you call it on a Windows platform. It does not accept any arguments to alter this, nor are there any delimter-conversion functions in the path package. There is an alternative to change the delimiter, forcing POSIX-style path.resolve() by calling path.posix.resolve(), however this removes the drive letter and does not work as a valid path on Windows. For example: What we need to pass to globPkg.sync(): `C:/Users/SomeName/Documents/Byond/cache` What path.resolve() returns: `C:\Users\SomeName\Documents\Byond\cache` What path.posix.resolve() returns: `/Users/SomeName/Documents/Byond/cache` Unfortunately there is not a method in the node path module to return what we need. Instead, we use the workaround provided in glob's documentation and add the windowsPathsNoEscape option. This COULD have a negative effect when searching for * and ? literals, however a search of resolveGlob() callers shows that none of them do this. * and ? in all callers is intended to be a wildcard, not a literal, so this won't have any impact on anything. ## Why It's Good For The Game Helps development efforts for developers using Windows.
## About The Pull Request - the .js extensions were required, this is my fault. - fixes a crash "automatic publicPath is not supported in this browser" ## Why It's Good For The Game Bug fixes. Dev server is working ## Changelog N/A nothing player facing
Glob package wasn't resolving tmp folder. Javascript does not clue you in that the arguments have changed at all. I downgraded the package and it works. Dev server is 100% confirmed working I swear if it breaks again I will... I will... N/A nothing player facing
About The Pull Request
Why It's Good For The Game
Changelog
🆑
/:cl: