Shuttle gibbing code improvements #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
changed the title
Adds a resistance flag, `SHUTTLE_CRUSH_PROOF`, adds it to the existing things that have it, and adds it to the immortality spectres. Gets rid of some hardcoded checks, making it easier for future code (or admins) to make things immune to shuttle crushing. Also makes it so immortality spectres are immune to being shuttle crushed, as that kinda ruins the whole "immortality" thing... :cl: refactor: Improved shuttle gibbing code, adding a new resistance flag, `SHUTTLE_CRUSH_PROOF`. fix: Immortality revival spectres can no longer be crushed by shuttles. add: The ghost of Poly can no longer be shuttle-crushed, nor can anything incorporeal. /:cl: Co-authored-by: san7890 <the@san7890.com>
Absolucy
force-pushed
the
shuttlecrush-fixup
branch
from
33f56ad
to
193a645
Compare
|
le random icebox failure has arrived |
This was referenced Mar 19, 2024
|
why would I let anything be immune to shuttle gibbed? that's a krill issue. |
This was referenced Mar 22, 2024
Open
This was referenced Mar 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a resistance flag,
SHUTTLE_CRUSH_PROOF, adds it to the existing things that have it, and adds it to the immortality spectres.Ports tgstation#81726
Why It's Good For The Game
Gets rid of some hardcoded checks, making it easier for future code (or admins) to make things immune to shuttle crushing.
Also makes it so immortality spectres are immune to being shuttle crushed, as that kinda ruins the whole "immortality" thing...
Changelog
馃啈
refactor: Improved shuttle gibbing code, adding a new resistance flag,
SHUTTLE_CRUSH_PROOF.fix: Immortality revival spectres can no longer be crushed by shuttles.
add: The ghost of Poly can no longer be shuttle-crushed, nor can anything incorporeal.
/:cl: