Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centcom arena now accounts for pacifism #1917

Merged

Conversation

LikeLakers2
Copy link

@LikeLakers2 LikeLakers2 commented May 16, 2024

About The Pull Request

Previously, you could enter the Centcom Arena as a pacifist character, and be unable to fight.

This PR now ensures pacifism is removed (from all sources) when a character is pulled into the arena.

Additionally, this PR also:

  • Refactors the prepping code, to avoid duplication
  • Fixes the examine text to have a space
  • Fixes the wagering so player_one is not pulled from twice.
  • Fixes the wagering so player_two can correctly earn their winnings.

Why It's Good For The Game

Allows pacifist characters to fight in the arena.

Changelog

🆑 MichiRecRoom
qol: The Centcom Arena now accepts pacifists! Their pacifism will be removed for the purposes of the fight.
fix: The Arena will now properly take the wager from each person's pocket, rather than twice from the first person's pocket.
/:cl:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants