NativeDetourTest on macOS shall not undo its failed detour either

MonoMod · Mar 23, 2022 · 5833f30 · 5833f30
1 parent cd8f77a
commit 5833f30
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/MonoMod.UnitTest/RuntimeDetour/NativeDetourTest.cs b/MonoMod.UnitTest/RuntimeDetour/NativeDetourTest.cs
@@ -136,11 +136,15 @@ public class NativeDetourTest {
                     d.Apply();
                 } catch (Win32Exception) {
                     // Modern macOS doesn't give us permission to mess with this anymore.
-                    d.Dispose();
+                    try {
+                        d.Dispose();
+                    } catch (Win32Exception) {
+                        // Of course it might also throw while trying to undo any made changes.
+                    }
                 }
             }
 
-            if (d.IsValid) {
+            if (d.IsApplied) {
                 DidNothing = true;
                 Assert.Equal(-1, libc_rand());
                 Assert.False(DidNothing);