Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes to work properly on old Unity Mono #183

Merged
merged 15 commits into from
Jun 8, 2024

Conversation

nike4613
Copy link
Collaborator

@nike4613 nike4613 commented Jun 2, 2024

No description provided.

@nike4613 nike4613 enabled auto-merge June 8, 2024 08:19
@nike4613 nike4613 merged commit 7e55f80 into MonoMod:reorganize Jun 8, 2024
61 checks passed
@slxdy
Copy link

slxdy commented Jun 8, 2024

The timing of this is amazing. I was literally just looking for a solution for the RuntimeType issue lol.

Can we got a build of this soon? I'm working on net20 support for my mod loader, and otherwise I'd have to fall back to the older versions of MonoMod

@nike4613
Copy link
Collaborator Author

nike4613 commented Jun 8, 2024

Can always use the CI builds. That said, net20? I don't think there's anything these days that requires net20. (Even truly ancient Unity games target net35.)

@slxdy
Copy link

slxdy commented Jun 8, 2024

Nope. There a lots of old mono games that use net20.
Also, the first commit in this PR is a fix specifically for net20

@slxdy
Copy link

slxdy commented Jun 8, 2024

Can always use the CI builds. That said, net20? I don't think there's anything these days that requires net20. (Even truly ancient Unity games target net35.)

Do those builds also get uploaded to nuget?

@nike4613
Copy link
Collaborator Author

nike4613 commented Jun 8, 2024

Nope. There a lots of old mono games that use net20. Also, the first commit in this PR is a fix specifically for net20

It's not, though. That's a fix that's present on old Mono, which is net35.

Do those builds also get uploaded to nuget?

Not at the moment. I want to have them upload to GitHub Packages, but haven't set that up just yet.

@slxdy
Copy link

slxdy commented Jun 8, 2024

Either way, I will just wait for the new nuget then. But thanks for merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants