Skip to content

Commit

Permalink
Merge pull request #325 from loic425/feature/add-missing-property-types
Browse files Browse the repository at this point in the history
Add missing property types
  • Loading branch information
loic425 committed Apr 26, 2021
2 parents 942c9bd + 35cb8a4 commit fa2c873
Show file tree
Hide file tree
Showing 47 changed files with 131 additions and 115 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG-0.6.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## Change Log

### v0.6.1 (2021/04/08 13:30 +00:00)

#### Details

- [#324](https://github.com/Monofony/Monofony/pull/324) Fix missing Doctrine migration (@loic425)

### v0.6.0 (2021/04/08 12:14 +00:00)

TL;DR
Expand Down
2 changes: 1 addition & 1 deletion src/Monofony/Bundle/CoreBundle/MonofonyCoreBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

class MonofonyCoreBundle extends Bundle
{
public const VERSION = '0.6.0';
public const VERSION = '0.6.1';

/**
* {@inheritdoc}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

final class DashboardStatisticsProvider implements DashboardStatisticsProviderInterface
{
private $statistics;
private iterable $statistics;

public function __construct(iterable $statistics)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

final class DashboardController
{
private $statisticsProvider;
private $twig;
private DashboardStatisticsProviderInterface $statisticsProvider;
private Environment $twig;

public function __construct(DashboardStatisticsProviderInterface $statisticsProvider, Environment $twig)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

class CustomerStatistic implements StatisticInterface
{
private $customerRepository;
private $twig;
private CustomerRepository $customerRepository;
private Environment $twig;

public function __construct(CustomerRepository $customerRepository, Environment $twig)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

final class AdminMenuBuilder implements AdminMenuBuilderInterface
{
private $factory;
private FactoryInterface $factory;

public function __construct(FactoryInterface $factory)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

final class LoggedInAppUserIdAwareDataTransformer implements DataTransformerInterface
{
private $security;
private Security $security;

public function __construct(Security $security)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

final class AppUserIdentifierNormalizer implements AppUserIdentifierNormalizerInterface
{
private $security;
private Security $security;

public function __construct(Security $security)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@

final class ChangeAppUserPasswordHandler implements MessageHandlerInterface
{
private $passwordUpdater;
private $userRepository;
private $entityManager;
private PasswordUpdaterInterface $passwordUpdater;
private UserRepositoryInterface $userRepository;
private EntityManagerInterface $entityManager;

public function __construct(
PasswordUpdaterInterface $passwordUpdater,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

final class RegisterAppUserHandler implements MessageHandlerInterface
{
private $appUserFactory;
private $appUserRepository;
private $customerProvider;
private FactoryInterface $appUserFactory;
private RepositoryInterface $appUserRepository;
private CustomerProviderInterface $customerProvider;

public function __construct(
FactoryInterface $appUserFactory,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@

final class ResetPasswordHandler implements MessageHandlerInterface
{
private $appUserRepository;
private $entityManager;
private $requestStack;
private $syliusResources;
private RepositoryInterface $appUserRepository;
private EntityManagerInterface $entityManager;
private RequestStack $requestStack;
private array $syliusResources;

public function __construct(
RepositoryInterface $appUserRepository,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@

final class ResetPasswordRequestHandler implements MessageHandlerInterface
{
private $customerRepository;
private $generator;
private $entityManager;
private $eventDispatcher;
private RepositoryInterface $customerRepository;
private GeneratorInterface $generator;
private EntityManagerInterface $entityManager;
private EventDispatcherInterface $eventDispatcher;

public function __construct(
RepositoryInterface $customerRepository,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

final class CustomerProvider implements CustomerProviderInterface
{
private $canonicalizer;
private $customerFactory;
private $customerRepository;
private CanonicalizerInterface $canonicalizer;
private FactoryInterface $customerFactory;
private RepositoryInterface $customerRepository;

public function __construct(
CanonicalizerInterface $canonicalizer,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@

final class CommandsRunner
{
private $entityManager;
private $progressBarCreator;
private EntityManagerInterface $entityManager;
private ProgressBarCreator $progressBarCreator;

public function __construct(
EntityManagerInterface $entityManager,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class DirectoryChecker
{
private $commandDirectoryChecker;
private CommandDirectoryChecker $commandDirectoryChecker;

public function __construct(CommandDirectoryChecker $commandDirectoryChecker)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

final class CommandExecutor
{
private $input;
private $output;
private $application;
private InputInterface $input;
private OutputInterface $output;
private Application $application;

public function __construct(InputInterface $input, OutputInterface $output, Application $application)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@

class InstallAssetsCommand extends Command
{
private $directoryChecker;
private $commandsRunner;
private $publicDir;
private $environment;
private DirectoryChecker $directoryChecker;
private CommandsRunner $commandsRunner;
private string $publicDir;
private string $environment;

public function __construct(
DirectoryChecker $directoryChecker,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,20 @@

class InstallCommand extends Command
{
private $directoryChecker;
private $cacheDir;
private DirectoryChecker $directoryChecker;
private string $cacheDir;

/**
* @var CommandExecutor|null
*/
private $commandExecutor;
private $commands = [

/**
* @var string[][]
*
* @psalm-var array{0: array{command: string, message: string}, 1: array{command: string, message: string}, 2: array{command: string, message: string}}
*/
private array $commands = [
[
'command' => 'database',
'message' => 'Setting up the database.',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

class InstallDatabaseCommand extends Command
{
private $databaseSetupCommandsProvider;
private $commandsRunner;
private $environment;
private DatabaseSetupCommandsProviderInterface $databaseSetupCommandsProvider;
private CommandsRunner $commandsRunner;
private string $environment;

public function __construct(
DatabaseSetupCommandsProviderInterface $databaseSetupCommandsProvider,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@

final class SetupCommand extends Command
{
private $adminUserManager;
private $adminUserFactory;
private $adminUserRepository;
private $validator;
private ObjectManager $adminUserManager;
private FactoryInterface $adminUserFactory;
private UserRepositoryInterface $adminUserRepository;
private ValidatorInterface $validator;

public function __construct(
ObjectManager $adminUserManager,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

class CreateClientCommand extends Command
{
private $clientManager;
private ClientManagerInterface $clientManager;

public function __construct(ClientManagerInterface $clientManager)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

class CustomerContext implements CustomerContextInterface
{
private $tokenStorage;
private $authorizationChecker;
private TokenStorageInterface $tokenStorage;
private AuthorizationCheckerInterface $authorizationChecker;

public function __construct(TokenStorageInterface $tokenStorage, AuthorizationCheckerInterface $authorizationChecker)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

final class CanonicalizerSubscriber implements EventSubscriber
{
private $canonicalizer;
private CanonicalizerInterface $canonicalizer;

public function __construct(CanonicalizerInterface $canonicalizer)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

final class UserRegistrationSubscriber implements EventSubscriberInterface
{
private $userManager;
private $tokenGenerator;
private $eventDispatcher;
private ObjectManager $userManager;
private GeneratorInterface $tokenGenerator;
private EventDispatcherInterface $eventDispatcher;

public function __construct(
ObjectManager $userManager,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

final class CustomerRegistrationFormSubscriber implements EventSubscriberInterface
{
private $customerRepository;
private RepositoryInterface $customerRepository;

public function __construct(RepositoryInterface $customerRepository)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

class CustomerSimpleRegistrationType extends AbstractResourceType
{
private $customerRepository;
private RepositoryInterface $customerRepository;

public function __construct(RepositoryInterface $customerRepository)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ final class CommandDirectoryChecker
*/
private $name;

private $filesystem;
private Filesystem $filesystem;

public function __construct(Filesystem $filesystem)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

final class DatabaseSetupCommandsProvider implements DatabaseSetupCommandsProviderInterface
{
private $doctrineRegistry;
private ManagerRegistry $doctrineRegistry;

public function __construct(ManagerRegistry $doctrineRegistry)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

final class UniqueAppUserEmailValidator extends ConstraintValidator
{
private $canonicalizer;
private $appUserRepository;
private CanonicalizerInterface $canonicalizer;
private UserRepositoryInterface $appUserRepository;

public function __construct(CanonicalizerInterface $canonicalizer, UserRepositoryInterface $appUserRepository)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

final class CustomerInitializer implements ObjectInitializerInterface
{
private $canonicalizer;
private CanonicalizerInterface $canonicalizer;

public function __construct(CanonicalizerInterface $canonicalizer)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@

class DefaultContext implements Context
{
protected $kernel;
protected KernelInterface $kernel;
protected $application;
protected static $sharedTester;
protected static ?CommandTester $sharedTester;
protected $command;
protected $questionHelper;

Expand All @@ -23,12 +23,12 @@ public function __construct(KernelInterface $kernel)
$this->kernel = $kernel;
}

public function setTester(CommandTester $tester): void
public function setTester(?CommandTester $tester): void
{
static::$sharedTester = $tester;
}

public function getTester(): CommandTester
public function getTester(): ?CommandTester
{
return static::$sharedTester;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

class InstallerContext extends DefaultContext
{
private $setupCommand;
private SetupCommand $setupCommand;
private $inputChoices = [
'e-mail' => 'test@email.com',
'password' => 'pswd',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

final class DoctrineORMContext implements Context
{
private $entityManager;
private EntityManagerInterface $entityManager;

public function __construct(EntityManagerInterface $entityManager)
{
Expand Down

0 comments on commit fa2c873

Please sign in to comment.