Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix coverage #21

Merged
merged 38 commits into from
Apr 19, 2020
Merged

💚 Fix coverage #21

merged 38 commits into from
Apr 19, 2020

Conversation

madmath03
Copy link
Member

@madmath03 madmath03 commented Dec 30, 2019

Please provide enough information so that others can review your pull request:

💚 fix coverage preventing sending to coveralls.io

Same issue as frappe/frappe#9169 and frappe/frappe#9304

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
@madmath03 madmath03 changed the title Ci/fix coverage 💚 Fix coverage Dec 30, 2019
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
@madmath03 madmath03 marked this pull request as ready for review March 26, 2020 20:43
madmath03 and others added 4 commits March 26, 2020 22:17
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: Emil <amionv99@gmail.com>
Signed-off-by: Emil <amionv99@gmail.com>
Signed-off-by: Emil <amionv99@gmail.com>
Copy link
Member Author

@madmath03 madmath03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AminovE99 This is breaking coveralls and coverage reports: https://travis-ci.org/github/Monogramm/erpnext_ocr/jobs/671612040#L1454

Couldn't use data file '/home/frappe/frappe-bench/.coverage': Looks like a coverage 4.x data file. Are you mixing versions of coverage?

Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
@madmath03 madmath03 merged commit 6aba938 into develop Apr 19, 2020
@madmath03 madmath03 deleted the ci/fix_coverage branch April 19, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants