The 'invalid' scope should be more obvious

[TheIronBorn]

Currently it seems invalid only makes the text italic and doesn't change colors at all.

Most color schemes do something like: (red background, bright foreground) and I feel something closer to that would be useful.

[s-clerc]

I’d prefer yellow and black, but I strongly agree.

[hovsater]

@Monokai would you mind taking a stab at this? Here's a concrete example:

Open a new document, set the syntax to Ocaml and enter the next 123xyz.

Using the default color scheme, Mariana, this is what we see:

Using any Monokai Pro color scheme, this is what we see:

The scope being used here is invalid.illegal.numeric.ocaml and I assume we want to add styling for invalid and invalid.deprecated as these are being defined by Mariana. See the snippet below:

{
  "name": "Invalid",
  "scope": "invalid",
  "foreground": "var(white2)",
  "background": "var(red)"
},
{
  "name": "Invalid deprecated",
  "scope": "invalid.deprecated",
  "foreground": "var(white2)",
  "background": "var(orange2)"
}

[hovsater]

In the meantime, anyone could customize the theme themselves to get around this by taking the following steps.

Open the Command Palette and select "UI: Customize Color Scheme". Under the rules property, add the following rules:

{
	"name": "Invalid",
	"scope": "invalid",
	"font_style": "normal",
	"foreground": "var(white)",
	"background": "var(red)"
},
{
	"name": "Invalid deprecated",
	"scope": "invalid.deprecated",
	"foreground": "var(white)",
	"background": "var(orange)"
}

[Monokai]

I've adjusted this in 1.1.21. I didn't adjust the background though, because I found that while you're typing, the partly typed code is often invalid, so you would have a lot of visual flickering.

I agree though that more prominent colors for invalid code are easier to spot when you quickly scroll through your code. So I think a red foreground color with an underline is a good compromise here.