Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON data serialisation done trough dictionaries, why not Codable? #12

Open
nedimf opened this issue Dec 26, 2021 · 2 comments
Open

JSON data serialisation done trough dictionaries, why not Codable? #12

nedimf opened this issue Dec 26, 2021 · 2 comments

Comments

@nedimf
Copy link

nedimf commented Dec 26, 2021 •
edited
Loading

JSON data serialisation done trough dictionary, instead of using Swift Codable protocols? Is there reason this SDK doesn't use well established JSON serialisation technic?
@nedimf nedimf changed the title JSON data serialisation done trough dictionary JSON data serialisation done trough dictionaries, why not Codable? Dec 26, 2021
@jasminsuljic
Copy link
Contributor

Is there reason this SDK doesn't use well established JSON serialisation technic?

There's no reason not to change to Codable. Is this something you'd be interested in?

@nedimf
Copy link
Author

nedimf commented Dec 27, 2021

Yeah, I could do PR by end of the week addressing this.
Thank you for your response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasminsuljic @nedimf