Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/#38 fix browser launcher #246

Merged

Conversation

3timeslazy
Copy link
Member

No description provided.

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ziflex ziflex merged commit 5188f9e into MontFerret:master Mar 3, 2019
@3timeslazy 3timeslazy deleted the feature/#38_fix_browser_launcher branch April 10, 2019 09:57
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* switch DebuggingAddress from 0.0.0.0 -> http://0.0.0.0:9222

* rename res -> path

* change exec.Command call and args

* set default cdp value to empty string
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* switch DebuggingAddress from 0.0.0.0 -> http://0.0.0.0:9222

* rename res -> path

* change exec.Command call and args

* set default cdp value to empty string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants