fix travis-ci(#28): use shell script instead of aliases #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
: json should parse as (values) None if input is nil.
krishnakarthik9
changed the title
ziflex
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #28
With this PR you can see that the travis build is success here for branch
travis-ci.PR Description
Previously
travis-ciis failing because its not able to identify aliases forantlr4and others. In this PR, aliases are substituted by one line shell script(created byecho -e "command" > filename).Even after this modification the travis-build fails. The error is due to a test case in
pkg/stdlib/strings/json_test.gowhereJsonParsewas not able to parsenone.So I fixed that too by parsing value
Noneif input isnil.