Feature/eval template #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
========================================
+ Coverage 35.4% 35.6% +0.2%
========================================
Files 335 338 +3
Lines 12249 12210 -39
========================================
+ Hits 4336 4347 +11
+ Misses 7494 7444 -50
Partials 419 419 |
3timeslazy
suggested changes
Sep 7, 2021
pkg/drivers/cdp/eval/function.go
Outdated
|
|
||
| func (fn *Function) withArg(arg runtime.CallArgument) *Function { | ||
| if fn.args == nil { | ||
| fn.args = make([]runtime.CallArgument, 0, 5) |
pkg/drivers/cdp/eval/helpers.go
Outdated
| return "function () {\n" + exp + "\n}" | ||
| } | ||
|
|
||
| var buf bytes.Buffer |
There was a problem hiding this comment.
use strings.Builder. It is more preferable for building strings and has the same API
| buf.WriteString("arg") | ||
| buf.WriteString(strconv.Itoa(i)) | ||
|
|
||
| if i != lastIndex { |
There was a problem hiding this comment.
There is an error in arguments part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New eval templates and interaction with HTML elements/