Feature/variables optimization #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tement returns NONE
…using '_' as a variable name
3timeslazy
reviewed
Sep 20, 2021
| if f.distinct { | ||
| // We need to check whether the value already exists in the result set | ||
| hash := value.Hash() | ||
| _, exists := f.hashTable[hash] |
There was a problem hiding this comment.
f.hashTable has type map[uint64]bool and value always true, so this can be rewritten as
if f.hashTable[hash] {
return
}There was a problem hiding this comment.
what if a key does not exist?
There was a problem hiding this comment.
If the key does not exist f.hashTable[hash] returns default value for bool which is false
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
========================================
- Coverage 35.9% 35.7% -0.2%
========================================
Files 349 351 +2
Lines 12621 12706 +85
========================================
+ Hits 4531 4536 +5
- Misses 7656 7734 +78
- Partials 434 436 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RETURN NONEreturn empty arrays now (almost zero-allocation)_name are ignored and do not get allocated to scope/stack.