Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Going back during collection setup can generate a broken traits.json #48

Open
Montspy opened this issue Apr 21, 2022 · 2 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Montspy
Copy link
Owner

Montspy commented Apr 21, 2022

A user hit the following error after generating a new collection:
image

The user did go back to a previous step while generating the traits.json file. After re-trying without going back during collection setup, the problem went away.
The bugged traits.json file was lost but the user will try to reproduce and share the file.

I believe that the traits.json file ended up with "animation": true but with an invalid value for the key "animation_size", causing the above error.

@sk33z3r is there a way to make the collection setup foolproof against going back to previous steps?

@sk33z3r
Copy link
Collaborator

sk33z3r commented Apr 21, 2022

I think your assessment is probably correct. It's doable, but a lot of holes in the UI have gone untouched because of the impending PR #47

@sk33z3r
Copy link
Collaborator

sk33z3r commented Jun 13, 2022

I'm not too sure what to do about this one. The way that POST works and how I save the file in between each step means it can get a little hairy. I think the whole mechanism will be revisited and fixed with a Mongo implementation, removing the need to store info in static text files, so content can be more dynamic.

@sk33z3r sk33z3r added this to the 2.0.0 milestone Jun 13, 2022
@sk33z3r sk33z3r added the bug Something isn't working label Jun 23, 2022
@sk33z3r sk33z3r self-assigned this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants