Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Base.isnan and friends for all multivectors #30

Open
tpgillam opened this issue Jan 29, 2024 · 1 comment
Open

Define Base.isnan and friends for all multivectors #30

tpgillam opened this issue Jan 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tpgillam
Copy link
Collaborator

We should also decide whether to implement Base.isinf.

Base.isfinite has a default implementation of isfinite(x::Number) = iszero(x - x), which we currently delegate to -- this seems to be sensible. But we should add tests for this regardless.

@tpgillam tpgillam added the enhancement New feature or request label Jan 29, 2024
@tpgillam
Copy link
Collaborator Author

Note that the built-in Complex type is a good model for e.g. what should happen if one component of a multivector is Inf and the other is NaN -- we should simply return true from both isnan and isinf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant